SyncListener for aspect templating #6871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also took the liberty to add proper error handling while doing so.
github-actions
bot
added
product: CLion
|
LGTM, but what happened to the MODULE.bazel.lock this time? 😅 |
LeFrosch
force-pushed
the
aspect-template-sync-listener
branch
from
02bd78a
to
4ba4f85
Compare
|
Committed the MODULE file by accident. It almost always is different from master for me. |
tpasternak
approved these changes
Oct 9, 2024
|
Thank you @LeFrosch |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the aspect templating code to a new SyncListener. This allows for tighter integration with the rest of the plugin and for proper error handling.